netdev - Re: [PATCH 3/6] pkt_sched: sch_generic: Add generic qdisc->ops->peek() implementation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Oct 2008 14:19:37 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Jarek Poplawski <jarkao2@...il.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH 3/6] pkt_sched: sch_generic: Add generic qdisc->ops->peek()
 implementation.

Jarek Poplawski wrote:
> pkt_sched: sch_generic: Add generic qdisc->ops->peek() implementation.
> 

> +	if (qops->peek == NULL)
> +		qops->peek = noop_qdisc_ops.peek;
>  	if (qops->dequeue == NULL)
>  		qops->dequeue = noop_qdisc_ops.dequeue;

->dequeue and ->peek are somewhat tied together, so I think we should
only use the noop variants if both are unset. Whether this should be
checked here of before merging new qdiscs is a different question of
course :)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html