netdev - Re: [PATCH] pkt_sched: Control group classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081017182312.GE20815@postel.suug.ch>
Date:	Fri, 17 Oct 2008 20:23:12 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH] pkt_sched: Control group classifier

* Andi Kleen <andi@...stfloor.org> 2008-10-16 07:41
> Thomas Graf <tgraf@...g.ch> writes:
> >
> > The principle of the classifier is to directly access the
> > task_struct via get_current(). In order for this to work,
> > classification requests from softirqs must be ignored.
> 
> You mean the classifier just wants to know if it runs
> as a softirq?

Yes, exactly.

> > This is
> > not a problem because the vast majority of packets in softirq
> > context are not assigned to a task anyway. For this to work, a
> > mechanism is needed to trace softirq context.
> > The only existing
> > way to do so is to use the TRACE_IRQFLAGS feature, unfortunately
> 
> Does't softirq_count() > 0 check that?

softirq_count() simply counts the levels of bh disable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html