netdev - Re: [PATCH 2/2] r8169: checks against wrong mac addresse init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081017200114.GA25222@electric-eye.fr.zoreil.com>
Date:	Fri, 17 Oct 2008 22:01:14 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Martin Capitanio <c4p7n@...itanio.org>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	jeff@...zik.org, Edward Hsu <edward_hsu@...ltek.com.tw>,
	Ivan Vecera <ivecera@...hat.com>,
	Petr Vandrovec <petr@...drovec.name>,
	Plamen Petrov <pvp-lsts@...ru.acad.bg>,
	J.A. Magallón <jamagallon@....com>
Subject: Re: [PATCH 2/2] r8169: checks against wrong mac addresse init

Martin Capitanio <c4p7n@...itanio.org> :
[...]
> Please take a look at the realtek r8101_n aka RealTek RTL8101E,
> RTL8102E(L) code. Only CFG_METHOD_1, CFG_METHOD_2
> and #(ioaddr, 0x00) == 0x8128 are here allowed to EEPROM access.

So Realtek's 810x driver eeprom code targets the 8101Eb and the
8101Ec only. It does not include Ivan's 8102el.

[...]
> static void
> rtl8101_check_eeprom(struct rtl8101_private *tp)
> {
[...]
> 	mac_addr_1 = rtl_eeprom_read_sc(ioaddr, 0x08);
> 	mac_addr_1 = mac_addr_1 << 16;
> 
> 	mac_addr_2 = rtl_eeprom_read_sc(ioaddr, 0x07);
> 	mac_addr_1 |= mac_addr_2;

The mac address is at the usual place.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html