netdev - Re: cxgb3: Fix kernel crash caused by uninitialized l2t

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081017.163113.225289906.davem@davemloft.net>
Date:	Fri, 17 Oct 2008 16:31:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rdreier@...co.com
Cc:	jeff@...zik.org, netdev@...r.kernel.org, divy@...lsio.com
Subject: Re: cxgb3: Fix kernel crash caused by uninitialized l2t_entry.arpq

From: Roland Dreier <rdreier@...co.com>
Date: Fri, 17 Oct 2008 14:18:26 -0700

> Commit 147e70e6 ("cxgb3: Use SKB list interfaces instead of home-grown
> implementation.") causes a crash in t3_l2t_send_slow() when an iWARP
> connection request is received.  This is because the new l2t_entry.arpq
> skb queue is never initialized, and therefore trying to add an skb to
> it causes a NULL dereference.  With the old code there was no need to
> initialize the queues because the l2t_entry structures were zeroed,
> and the code used NULL to mean empty.
> 
> Fix this by adding __skb_queue_head_init() when all the l2t_entry
> structures get allocated.
> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>

Acked-by: David S. Miller <davem@...emloft.net>

> This should probably go to -stable as well, since it looks like the
> commit that broke things went into 2.6.27-rc6.

Indeed.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html