netdev - Re: [PATCH] pkt_sched: Control group classifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081018053810.GC12825@one.firstfloor.org>
Date:	Sat, 18 Oct 2008 07:38:10 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	Andi Kleen <andi@...stfloor.org>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] pkt_sched: Control group classifier

On Fri, Oct 17, 2008 at 10:09:16PM +0200, Thomas Graf wrote:
> * Andi Kleen <andi@...stfloor.org> 2008-10-17 20:32
> > > softirq_count() simply counts the levels of bh disable.
> > 
> > softirqs always have bh disabled.  So it's always true inside them.
> > And you should know what _bh locks you hold.
> 
> I actually tried "softirq_count() == SOFTIRQ_OFFSET" to see if the

softirq_count() > 0 should work.


> I found explicitely counting softirq_enter() to be more reliable
> without having much of a performance impact. I'm happy with both
> solutions though.

I doubt you'll need a separate ocunter.

-Andi 

-- 
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html