netdev - Re: [PATCH] pkt_sched: sch_generic: Fix oops in sch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081019.233811.252670245.davem@davemloft.net>
Date:	Sun, 19 Oct 2008 23:38:11 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jarkao2@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] pkt_sched: sch_generic: Fix oops in sch_teql

From: Jarek Poplawski <jarkao2@...il.com>
Date: Sun, 19 Oct 2008 01:09:38 +0200

> pkt_sched: sch_generic: Fix oops in sch_teql
> 
> After these commands:
> # modprobe sch_teql
> # tc qdisc add dev eth0 root teql0
> # tc qdisc del dev eth0 root
> we get an oops in teql_destroy() when spin_lock is taken from a null
> qdisc_sleeping pointer. It's because at the moment teql0 dev haven't
> been activated yet, and a qdisc_root_sleeping() is pointing to noop
> qdisc's netdev_queue with qdisc_sleeping uninitialized. This patch
> fixes this both for noop and noqueue netdev_queues to avoid similar
> problems in the future.
> 
> Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
> [regression in 2.6.27]

Applied and will queue to -stable, thanks Jarek.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html