netdev - Re: [PATCH] sky2: skb recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48FDCE3D.9050801@cosmosbay.com>
Date:	Tue, 21 Oct 2008 14:42:37 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Robert Olsson <robert@...ur.slu.se>
Cc:	Terry <hanfang@...du.com>,
	Robert Olsson <Robert.Olsson@...a.slu.se>,
	Stephen Hemminger <shemminger@...tta.com>,
	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: skb recycling

Robert Olsson a écrit :
> Terry writes:
>  > Hi 
>  >     yeah. In the forwarding scenario , skb recycling should boost the 
>  > performance by avoiding slowpath slub alloc/free .But if  using 
>  > multiqueue hardware and assigning proper  cpu affinities  could  make it 
>  > always in the fastpath of slub  alloc/free, which is faster?
> 
>  For perfect setup with monotone work like forwarding you can make the skb 
>  recycling a little faster.
> 
>  If you have many active NIC's and the recycling list is per device the situation
>  it's probably different...
> 

I suspect all this skb recycling stuff in forwarding workloads is defeated anyway...

By the copybreak feature... (RX_COPY_THRESHOLD = 256 for example on tg3)

Checking drivers/net/tg3.c, we can even see that in case of copying to a smaller skb,
we allocate it with a call to netdev_alloc_skb(), while it would be better
to use a plain alloc_skb() ...




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html