netdev - Re: [PATCH 14/16] RealView: Use the in-kernel smc911x.c driver on RealView

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081021184653.GA15027@flint.arm.linux.org.uk>
Date:	Tue, 21 Oct 2008 19:46:53 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Steve.Glendinning@...c.com
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Bill Gatliff <bgat@...lgatliff.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	linux-arm-kernel@...ts.arm.linux.org.uk, Ian.Saturley@...c.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 14/16] RealView: Use the in-kernel smc911x.c driver on	RealView

On Tue, Oct 21, 2008 at 11:26:42AM +0100, Steve.Glendinning@...c.com wrote:
> Almost all the feedback I've had has been positive, but I've had a few
> "can't you just fix the in-tree driver?" responses.  The trouble is it's
> not a *small* piece of work!

Which is reasonable given your summary, since...

> smsc911x
> - uses functions instead of macros, making it more readable
> - uses napi (and manages significantly higher throughput because of it)
> - uses phylib
> - passes checkpatch.pl
> - has workarounds for older LAN911x variants
> 
> smc911x
> - is already in-tree (not really technical, but still important)
> - has support for pxa dma*
> - has dynamic bus width config

.. we want to avoid having two drivers for the same device, but not
supporting these features would be seen as a regression.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html