netdev - Re: [PATCH] sky2: skb recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081021133811.68bd5ce1@extreme>
Date:	Tue, 21 Oct 2008 13:38:11 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	Rick Jones <rick.jones2@...com>,
	David Miller <davem@...emloft.net>, jgarzik@...ox.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] sky2: skb recycling

On Tue, 21 Oct 2008 22:15:43 +0200
Eric Dumazet <dada1@...mosbay.com> wrote:

> Rick Jones a écrit :
> > David Miller wrote:
> >> From: Stephen Hemminger <shemminger@...tta.com>
> >> Date: Mon, 20 Oct 2008 19:09:22 -0700
> >>
> >>
> >>> Add support for recycling tx buffers into receive buffers.
> >>> This is experimental at this point.
> >>>
> >>> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> >>
> >>
> >> Experimental, but do you have any performance data at all?
> >> Just curious...
> > 
> > I've not had a good emily litella moment all day so I'll ask - is there 
> > really that much in the way of suitable skb's which are completely free 
> > after transmit completion?
> 
> Or, if we take another way, say a VOIP RTP machine sends and receive 20.000
>  packets per second, each being 200 bytes long, are transmited packets
> correctly sized at sendto() time to be candidates for recycling ?

No. Most locally generate packets aren't going to be right size because
they will be too small, cloned or fragmented.  It really only helps when forwarding.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html