netdev - Re: [RFC 1/2] igb: statistic optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081022105458.59814157@extreme>
Date:	Wed, 22 Oct 2008 10:54:58 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Rick Jones <rick.jones2@...com>
Cc:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"jeffery.t.kirsher@...el.com" <jeffery.t.kirsher@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [RFC 1/2] igb: statistic optimization

On Wed, 22 Oct 2008 10:37:44 -0700
Rick Jones <rick.jones2@...com> wrote:

> > I don't think you want to put this in the code that can be called directly 
> > from IOCTL from userspace.  This function can take a lot of cycles and 
> > some silly applications like gkrellm call it quite frequently.  The 
> > update_stats function will be called as part of the watchdog anyway, and 
> > you already got the interesting stats for realtime with the tx and rx 
> > bytes/packets.
> 
> On the flip side aren't there "out of phase" issues with pulling stats 
> based on a timer vs something like a netstat -i 1 command?
> 
> rick jones

The only stats pulled are the error stats, so this is probably okay.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html