netdev - Re: Regression: Recent networking (qdisc?) patches break irda_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081023.172129.179937745.davem@davemloft.net>
Date:	Thu, 23 Oct 2008 17:21:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jesse.brandeburg@...el.com
Cc:	avillaci@...bo.fiec.espol.edu.ec, irda-users@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: Regression: Recent networking (qdisc?) patches break
 irda_get_next_speed()

From: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Date: Thu, 23 Oct 2008 15:13:02 -0700

> Isn't this what the data that is skb_reserve'd at the beginning of
> skb's allocated by netdev_alloc_skb is for?  If you take an extra
> reference to the skb and/or use a destructor hook you should be
> good, right?
>
> you should just be able to push ->data using skb_reserve(sizeof your
> private data) in the beginning of the skb, or is that a horrible
> idea Dave?

This area of the SKB data is still volatile.

Let's say a packet scheduler classifier causes a TC action
to execute which pushes stuff there, it'll get overwritten.

Really, this idea won't work.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html