netdev - Re: WARNING (skb_gso_segment) with tg3+bridge in 2.6.27

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081024143323.GA14344@gondor.apana.org.au>
Date:	Fri, 24 Oct 2008 22:33:23 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Michael Chan <mchan@...adcom.com>
Cc:	Matthew Carlson <mcarlson@...adcom.com>,
	David Miller <davem@...emloft.net>,
	"berni@...kenwald.de" <berni@...kenwald.de>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: WARNING (skb_gso_segment) with tg3+bridge in 2.6.27

On Thu, Oct 23, 2008 at 10:13:25AM -0700, Michael Chan wrote:
> 
> Yes, NETIF_F_TSO6 chips are a subset of NETIF_F_IPV6_CSUM chips.  In the
> code, these 2 bits are set independently and so the relationship is not
> obvious.  We should probably rearrange the code to make things more
> clear.

That's good to know.  I was afraid of adding a check in the
dev registration function in case your card actually needed
this.  Now that I know it doesn't we can check and disable it
if ever it happens.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html