netdev - Re: PCI VPD size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200810241418.38733.jbarnes@virtuousgeek.org>
Date:	Fri, 24 Oct 2008 14:18:38 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	"Benjamin Li" <benli@...adcom.com>, netdev@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: Re: PCI VPD size

On Friday, October 24, 2008 12:50 pm Stephen Hemminger wrote:
> Why did you choose to limit VPD access by using PCI quirks:
>  
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h
>=99cb233d60cbe644203f19938c729ea2bb004d70
>
> Rather than controlling size in the device driver which is what my
> patches (which seem to have been ignored) did:
>   http://marc.info/?l=linux-netdev&m=122393195716363&w=2
>
> The problem with the quirk scheme is that it means putting more
> per device settings in a location farther away in the source code
> than the underlying device driver.

The last status I received on that was a comment from Jeff about assuming the 
maximum size for the VPD space.  That's the whole reason we have the quirks: 
on many devices accessing beyond the end of VPD space can cause a device hang.  
And since that space is available from a sysfs file we need to be extra 
careful.

Other than that, your patches looked fine, I was just waiting for you to 
address that last comment.

-- 
Jesse Barnes, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html