netdev - Re: [PATCH 1/1] r8169: revert "read MAC address from EEPROM on init"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49049A33.2080203@pobox.com>
Date:	Sun, 26 Oct 2008 12:26:27 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Francois Romieu <romieu@...zoreil.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alistair John Strachan <alistair@...zero.co.uk>,
	Ivan Vecera <ivecera@...hat.com>,
	Chuck Ebbert <cebbert@...hat.com>,
	Krzysztof Halasa <khc@...waw.pl>,
	Petr Vandrovec <petr@...drovec.name>,
	Plamen Petrov <pvp-lsts@...ru.acad.bg>,
	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>,
	"J.A. Magallón" <jamagallon@....com>,
	Jiri Slaby <jirislaby@...il.com>,
	Simon Arlott <simon@...e.lp0.eu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Edward Hsu <edward_hsu@...ltek.com.tw>
Subject: Re: [PATCH 1/1] r8169: revert "read MAC address from EEPROM on init"

Francois Romieu wrote:
> This reverts commit 7bf6bf4803df1adc927f585168d2135fb019c698.
> 
> The code has both a short existence and an increasing track
> of failures despite some work to amend it for -rc1. It is not
> just a matter of reading the eeprom: sometimes the eeprom is
> read correctly, then the mac address is not written correctly
> back into the mac registers.
> 
> Some chipsets seem to work reliably but it is not clear at
> this point if the code can simply be made to work on a
> per-chipset basis and post -rc1 is not the place where I want
> to experiment these things.
> 
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>

Acked-by: Jeff Garzik <jgarzik@...hat.com>

I'll send upstream if Linus doesn't pick it up shortly...


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html