netdev - [PATCH] at91_ether: multicast packet are not received due to incorrect setting of the multicast hashtable, kernel linux-2.6.17.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 26 Oct 2008 23:31:17 +0600
From:	"Leonid Slobodchikov" <curvex@...il.com>
To:	netdev@...r.kernel.org
Cc:	linux-arm-kernel@...ts.arm.linux.org.uk
Subject: [PATCH] at91_ether: multicast packet are not received due to incorrect setting of the multicast hashtable, kernel linux-2.6.17.3

Hello,

Multicast packets are not received by the Ethernet driver for the
Atmel AT91RM9200. This is due to incorrect mc_filter array index
evaluation in the at91ether_sethashtable function. The point is that
AT91_EMAC_HSH and AT91_EMAC_HSL registers are 64-bit length. So when
evaluating the index the bit number must be diveded at 64, which is
2^6, not 2^5.
The below is a fix for that issue.

--- drivers/net/arm/at91_ether.c.orig	2006-06-30 20:37:38.000000000 +0300
+++ drivers/net/arm/at91_ether.c	2008-10-26 17:35:50.000000000 +0200
@@ -520,7 +520,7 @@ static void at91ether_sethashtable(struc
 		if (!curr) break;	/* unexpected end of list */

 		bitnr = hash_get_index(curr->dmi_addr);
-		mc_filter[bitnr >> 5] |= 1 << (bitnr & 31);
+		mc_filter[bitnr >> 6] |= 1 << (bitnr & 31);
 	}

 	at91_emac_write(AT91_EMAC_HSH, mc_filter[0]);

Signed-off-by: Leonid V. Slobodchikov <curvex@...il.com>

Best regards,
Leonid Slobodchikov

Download attachment "at91_ether.patch.gz" of type "application/x-gzip" (362 bytes)