netdev - Re: tbench wrt. loopback TSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081027.113904.211811887.davem@davemloft.net>
Date:	Mon, 27 Oct 2008 11:39:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	zbr@...emap.net
Cc:	ilpo.jarvinen@...sinki.fi, netdev@...r.kernel.org, efault@....de,
	mingo@...e.hu, a.p.zijlstra@...llo.nl, herbert@...dor.apana.org.au
Subject: Re: tbench wrt. loopback TSO

From: Evgeniy Polyakov <zbr@...emap.net>
Date: Mon, 27 Oct 2008 20:03:14 +0300

> On Mon, Oct 27, 2008 at 05:19:17PM +0200, Ilpo Järvinen (ilpo.jarvinen@...sinki.fi) wrote:
> > Noticed that tcp_current_mss does modulo with tso and that it is 
> > being called from a non-trivial number of places, though ovbiously only 
> > part of them should be relevant here. ...I'm not sure if that can show 
> > up though.
> 
> That's why when I see modulo something screams inside me...
> I used following patch (without goto in the tcp_tso_should_defer():

Indeed, those modulos are the worst part about the TSO code.

I'll see what I can do to get rid of them, I hate them too. :-)

One idea immediately occurs to me.  Since we're effectively limited
to a 64K TSO frame, and the MSS is some value smaller than that, we
can probably get away with a reciprocol divide.  Even using a 16-bit
inverse value would suffice, so we wouldn't need to use u64's like
some other pieces of code do.  A u32 would be enough.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html