netdev - Re: [PATCH] ibm_newemac: Fix typo in flow control config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49060DFA.7090901@garzik.org>
Date:	Mon, 27 Oct 2008 14:52:42 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Josh Boyer <jwboyer@...ux.vnet.ibm.com>
CC:	benh@...nel.crashing.org, hch@....de, linuxppc-dev@...abs.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ibm_newemac: Fix typo in flow control config option

Josh Boyer wrote:
> The recent build fix for ibm_newemac has a typo in the config
> option #ifdef used for disabling flow control.  This corrects
> it to the proper Kconfig option name.
> 
> Reported-by: Christoph Hellwig <hch@....de>
> Signed-off-by: Josh Boyer <jwboyer@...ux.vnet.ibm.com>
> 
> ---
> 
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index 2ee2622..901212a 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -2605,7 +2605,7 @@ static int __devinit emac_init_config(struct emac_instance *dev)
>  		    of_device_is_compatible(np, "ibm,emac-440gr"))
>  			dev->features |= EMAC_FTR_440EP_PHY_CLK_FIX;
>  		if (of_device_is_compatible(np, "ibm,emac-405ez")) {
> -#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
> +#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL
>  			dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
>  #else
>  			printk(KERN_ERR "%s: Flow control not disabled!\n",

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html