netdev - Re: [PATCH] net: don't use INIT_RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081028.132521.120536910.davem@davemloft.net>
Date:	Tue, 28 Oct 2008 13:25:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	paulmck@...ux.vnet.ibm.com
Cc:	adobriyan@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: don't use INIT_RCU_HEAD

From: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Date: Tue, 28 Oct 2008 09:10:17 -0700

> On Tue, Oct 28, 2008 at 04:31:24PM +0300, Alexey Dobriyan wrote:
> > call_rcu() will unconditionally rewrite RCU head anyway.
> > Applies to 
> > 	struct neigh_parms
> > 	struct neigh_table
> > 	struct net
> > 	struct cipso_v4_doi
> > 	struct in_ifaddr
> > 	struct in_device
> > 	rt->u.dst
> 
> Assuming that no code outside of RCU is testing the rcu_head fields...
> That would usually be a bad idea in any case, as call_rcu() makes no
> guarantee about the values of these fields after the callback is invoked.
> Furthermore, there have been serious proposals that would change the
> call_rcu() field names and layout.
> 
> Therefore:
> 
> Acked-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

I've applied this patch, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html