netdev - Re: [PATCH] xfrm: Notify changes in UDP encapsulation via netlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225226660.6976.18.camel@martin>
Date:	Tue, 28 Oct 2008 21:44:20 +0100
From:	Martin Willi <martin@...ongswan.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] xfrm: Notify changes in UDP encapsulation via netlink

> I don't see the code which will actually invoke the new
> ->new_mapping() method (either here or in a follow-on patch), so it's
> impossible to review these changes.

The patch is complete, sorry for being unclear.

xfrm_send_mapping is an implementation of a xfrm_mgr operation. 

>  static struct xfrm_mgr netlink_mgr = {
>         .id             = "netlink",
>         .notify         = xfrm_send_state_notify,
>         .notify_policy  = xfrm_send_policy_notify,
>         .report         = xfrm_send_report,
>         .migrate        = xfrm_send_migrate,
> +       .new_mapping    = xfrm_send_mapping,
> };

This operation is invoked from net/ipv4/esp4.c through the
km_new_mapping() function, km_new_mapping() invokes all registered key
managers. It is already implemented in the PF_KEY interface (pfkeyv2_mgr
in af_key.c), but is missing in the netlink xfrm interface. The patch
adds this functionality to the netlink interface.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html