netdev - Re: [PATCH 4/6v2] netfilter: replace uses of NIP6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1225233757.5269.211.camel@localhost>
Date:	Tue, 28 Oct 2008 15:42:36 -0700
From:	Joe Perches <joe@...ches.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 4/6v2] netfilter: replace uses of NIP6_FMT with %p6

On Tue, 2008-10-28 at 13:13 -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> diff --git a/net/netfilter/nf_conntrack_ftp.c
> b/net/netfilter/nf_conntrack_ftp.c
> index 4f71071..a90d463 100644
> --- a/net/netfilter/nf_conntrack_ftp.c
> +++ b/net/netfilter/nf_conntrack_ftp.c
> @@ -467,11 +467,9 @@ static int help(struct sk_buff *skb,
>  				 NIPQUAD(cmd.u3.ip),
>  				 NIPQUAD(ct->tuplehash[dir].tuple.src.u3.ip));
>  		} else {
> -			pr_debug("conntrack_ftp: NOT RECORDING: " NIP6_FMT
> -				 " != " NIP6_FMT "\n",
> -				 NIP6(*((struct in6_addr *)cmd.u3.ip6)),
> -				 NIP6(*((struct in6_addr *)
> -					ct->tuplehash[dir].tuple.src.u3.ip6)));
> +			pr_debug("conntrack_ftp: NOT RECORDING: %p6 != %p6\n",
> +				 cmd.u3.ip6, 
> +				 ct->tuplehash[dir].tuple.src.u3.ip6);
>  		}

I think it's better to change all uses of:
  (foo.<ie: ct->tuplehash[dir].tuple.src.>)u3.ip6
to:
  &foo.u3.in6

as the union defines a struct in6_addr and not use the
ip6 array which is __be32[4].

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html