netdev - Re: [RFC PATCHv3] printk: add %pM format specifier for MAC addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1225181186.3796.71.camel@johannes.berg>
Date:	Tue, 28 Oct 2008 09:06:26 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Harvey Harrison <harvey.harrison@...il.com>,
	David Miller <davem@...emloft.net>, anders@...uras.de,
	netdev@...r.kernel.org, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCHv3] printk: add %pM format specifier for MAC
	addresses

On Mon, 2008-10-27 at 17:22 -0700, Joe Perches wrote:
> On Mon, 2008-10-27 at 17:05 -0700, Harvey Harrison wrote:
> > On Mon, 2008-10-27 at 16:55 -0700, David Miller wrote:
> > > I'm ok with the '#' modifier but remind me again what's wrong with
> > > using plain %p4 and %p6?
> > Nothing at all, just wanted to know what color bikeshed you wanted.
> > I'll go with %p4 %p6.
> 
> Just an FYI for v6 addresses:
> 
> There are a few uses of ipv6 address as "%08X%08X%08X%08X" 
> Pavel Emelyanov tried to isolate them with a suggested patch:
> 
> http://www.mail-archive.com/netdev@vger.kernel.org/msg51655.html
> 
> These addresses are not shown in network order, but are
> printed backwards in host order. Oops.  Apparently it's
> too late to fix them.

So that code we don't touch here at all.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)