netdev - Re: [PATCH] net: don't use INIT_RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081028160548.GE6779@linux.vnet.ibm.com>
Date:	Tue, 28 Oct 2008 09:05:48 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Patrick McHardy <kaber@...sh.net>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: don't use INIT_RCU_HEAD

On Tue, Oct 28, 2008 at 06:43:41PM +0300, Alexey Dobriyan wrote:
> On Tue, Oct 28, 2008 at 04:29:06PM +0100, Patrick McHardy wrote:
> > Alexey Dobriyan wrote:
> >> call_rcu() will unconditionally rewrite RCU head anyway.
> >> Applies to 	struct neigh_parms
> >> 	struct neigh_table
> >> 	struct net
> >> 	struct cipso_v4_doi
> >> 	struct in_ifaddr
> >> 	struct in_device
> >> 	rt->u.dst
> >
> > It would probably make sense to get a statement from Paul
> > whether this might be required in the future, f.i. for some
> > debugging feature.
> 
> Let's cc him :-)

Can't say that I would be all that upset if INIT_RCU_HEAD() were to
simply vanish.  So I have no problem with it being removed from the
above functions.

Suppose I might as well find the original and Ack it.  ;-)

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html