netdev - Re: [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Oct 2008 14:35:40 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	jeff@...zik.org, netdev@...r.kernel.org
Subject: Re: [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings

On Wed, 29 Oct 2008 21:29:04 +0000
Ben Hutchings <bhutchings@...arflare.com> wrote:

> On Wed, 2008-10-29 at 14:22 -0700, akpm@...ux-foundation.org wrote:
> > From: Andrew Morton <akpm@...ux-foundation.org>
> > 
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_write_limit':
> > drivers/net/sfc/falcon.c:1679: warning: comparison of distinct pointer types lacks a cast
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_read':
> > drivers/net/sfc/falcon.c:1720: warning: comparison of distinct pointer types lacks a cast
> 
> These were already fixed by 31b760202a0911384fa07796df9d1905e9e89a7f.

That patch worsened things.

> > Driver seems rather confused about types.  Try to help it.
> [...]
> 
> Maybe, but in order to fix that you'll need to revert
> 31b760202a0911384fa07796df9d1905e9e89a7f along with making these
> changes.

I have plenty of things to be going on with.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html