netdev - Re: New filter 'flow' bug?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081029140905.586E4E4357B@f11.poczta.interia.pl>
Date:	29 Oct 2008 15:09:05 +0100
From:	almaop@...zta.fm
To:	Patrick McHardy <kaber@...sh.net>,
	"almaop@...zta.fm" <almaop@...zta.fm>
Cc:	David Miller <davem@...emloft.net>,
	"linux-net@...r.kernel.org" <linux-net@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: New filter 'flow' bug?

> > From: almaop@...zta.fm
> > Date: 29 Oct 2008 08:27:05 +0100
> >> My configuration: gentoo, kernel 2.6.26.7 + imq patch + l7 patch, glibc
> 2.7, iproute2 2.6.26. Shaping is done on ethernet (e1000 card) but as I see
> on the ifb nothing changes.
> >> There are htb 3 classes with sfq as their qdiscs. It is simple,
> something like:
> >>
> >> tc qdisc add dev $DEV root handle 1: htb default 4 tc class add dev
> $DEV parent 1: classid 1:1 htb rate 78kbps ceil 78kbps overhead 0 linklayer
> atm
> >>
> >> tc class add dev $DEV parent 1:1 classid 1:2 htb rate 20kbps ceil
> 20kbps overhead 0 linklayer atm prio 3
> >> tc class add dev $DEV parent 1:1 classid 1:3 ...
> >> tc class add dev $DEV parent 1:1 classid 1:4 ...
> >>  
> >> tc qdisc add dev $DEV parent 1:2 handle 2: sfq quantum 64
> >> tc qdisc add dev $DEV parent 1:3 handle 3: sfq
> >> tc qdisc add dev $DEV parent 1:4 handle 4: sfq
> >>
> >> tc filter add dev $DEV parent 1: ....
> >> ....
> >>  
> >> tc filter add dev $DEV parent 2: protocol ip handle 1 prio 12 flow 
> >> hash keys dst,proto,proto-dst divisor 128
> >>
> >> tc filter add dev $DEV parent 3: protocol ip handle 1 prio 12 flow 
> >> hash keys dst,proto,proto-dst divisor 128
> >>
> >> tc filter add dev $DEV parent 4: protocol ip handle 1 prio 12 flow 
> >> hash keys nfct-src,nfct-dst,proto,nfct-proto-src,nfct-proto-dst divisor
> 128
> >>
> >> I'm not sure where is the bug - in the flow filter or in the sfq
> qdisc.
> 
> Which SFQ qdisc is stalling?
> 
Thanks for reply.
So I've done few tests. I've removed quantum 64 (it  was qdisc with small packets). It made no difference. It looks like the key is the first sfq qdisc (tc qdisc add dev $DEV parent 1:2 handle 2: sfq - in my example). When there is no traffic in this qdisc for about 45 seconds (shorter time when there is no traffic at all on the interface) - it stalls. Other qdiscs stall also. So there is no packet flow on that interface. Removing filters ('flow' filters) does'nt help. I have to remove (all) sfq qdiscs. And then the traffic is resumed.
Regards.

Krzysiek


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html