| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Oct 2008 08:39:19 -0700 From: Joe Perches <joe@...ches.com> To: Harvey Harrison <harvey.harrison@...il.com> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org Subject: Re: oh crap... (re: %p6) On Wed, 2008-10-29 at 07:55 -0700, Harvey Harrison wrote: > On Wed, 2008-10-29 at 01:54 -0700, David Miller wrote: > > I think we'll need to revert all of this or find some fix soon. GCC > > warns about %p with a '#' flag modifier it seems :-( > > > > net/ipv6/ip6_flowlabel.c: In function 'ip6fl_seq_show': > > net/ipv6/ip6_flowlabel.c:707: warning: '#' flag used with '%p' printf format > > The easiest would be to pick a separate modifier for the raw case. Or > revert the removal of NIP6_SEQFMT, I'll shoot you a patch shortly, > any preference in what modifier should be used? I'd prefer something visual that represents "no colon". Maybe %p6-: Or perhaps slightly worse to change the colon separated default %p6 to %p:6 There are another cases where the v6 address should have as few leading zeros as possible or where the interior zeros should be collapsed using :: separators. Perhaps a good solution is to use the equivalent of a "display-hint" after the %p6 Maybe use combinations of: %p6:: use "::" and collapse when 0 %p6-: raw hex %p6-0 %x not %04x %p6.4 last u32 as ipv4 dotted decimal -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists