netdev - Re: [PATCH] bpa10x: free sk_buff with kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2008 05:09:34 +0100
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	David Miller <davem@...emloft.net>, Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] bpa10x: free sk_buff with kfree_skb

Hi Ilpo,

>> 2) Couple places trying to pass sk_buff to kfree() instead of
>>   kfree_skb().  Fixed by Sergio Luis
>
> I tried with coccinelle and found one more of these, though my
> other attempts with it haven't been all that successful...
>
>
> --
> [PATCH] bpa10x: free sk_buff with kfree_skb
>
> Inspired by Sergio Luis' similar patches, I finally found
> a case which is trivial enough that spatch won't choke
> on it.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

good catch.

Acked-by: Marcel Holtmann <marcel@...tmann.org>

Dave, feel free to take this directly and apply it to your trees.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html