| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <49097C95.2040806@trash.net> Date: Thu, 30 Oct 2008 10:21:25 +0100 From: Patrick McHardy <kaber@...sh.net> To: Changli Gao <xiaosuo@...il.com> CC: Jarek Poplawski <jarkao2@...il.com>, netdev@...r.kernel.org Subject: Re: [PATCH] HTB updates class's bstats in one place Changli Gao wrote: > On Thu, Oct 30, 2008 at 3:11 PM, Patrick McHardy <kaber@...sh.net> wrote: >> Independant of this statistics bug, according to your description >> you want to measure departure rates (otherwise the measured rates >> can't really be compared to the limit) and the current counters are >> not really suitable for this since they count arriving packets. >> So the only way to properly do this is to add seperate counters that >> account for departing packets. I think this would be a good addition >> since we've always been advocating to do this stuff in userspace, >> but it would need some thought on how to minimize the impact for >> people not needing it. >> >> > In fact, only the counters of the leaf classes represent arriving > rates, but the others represent departing rates. Is it right? Or does > it need to be fixed? Its not correct, but I wouldn't fix it at this time unless you can suggest a good way that doesn't require to walk the entire hierarchy during ->enqueue() just for the class counters. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists