netdev - Re: [PATCH] [PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200810300916.01468.jbarnes@virtuousgeek.org>
Date:	Thu, 30 Oct 2008 09:16:00 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	"Allan, Bruce W" <bruce.w.allan@...el.com>
Cc:	Jeff Garzik <jeff@...zik.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] [PCI] move ICHx GbE NVM write-protection from e1000e to PCI quirk

On Monday, October 27, 2008 1:26 pm Allan, Bruce W wrote:
> >> This PCI quirk is put in ./drivers/net/e1000e in order to share
> >> defines and structs found in the driver source, and is only applicable
> >> to ICHx GbE LOMs supported by that driver anyway.
> >
> >Seems to be it is not difficult to put it into drivers/pci/quirks.c,
> >where it belongs.
> >
> >	Jeff
>
> Yes, it wouldn't be difficult to put it elsewhere but does it really belong
> in drivers/pci/quirks.c?  The quirk is applicable only to the GbE LOM found
> on Intel ICH8/9/10-based platforms so one could argue it should be in
> arch-specific code (arch/x86/pci/fixup.c).  OTOH, quirks in driver
> directories are not unprecedented (e.g. drivers/clocksource/acpi_pm.c,
> drivers/usb/host/pci-quirks.c).  I patched it into the driver's directory
> as it would be an obvious reminder when adding support for future parts to
> check whether the quirk is applicable and update the list of devices
> accordingly.
>
> So, what is the "right" place?

If you think it's likely to apply to future devices as well, I'd say you may 
as well keep it in the driver.

Jesse


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html