[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081030171019.11396.40616.stgit@flek.lan>
Date: Thu, 30 Oct 2008 13:10:19 -0400
From: Paul Moore <paul.moore@...com>
To: netdev@...r.kernel.org
Subject: [PATCH 1/3] cipso: unsigned buf_len cannot be negative
From: roel kluin <roel.kluin@...il.com>
unsigned buf_len cannot be negative
Signed-off-by: Roel Kluin <roel.kluin@...il.com>
Signed-off-by: Paul Moore <paul.moore@...com>
---
net/ipv4/cipso_ipv4.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
index 490e035..2e78f6b 100644
--- a/net/ipv4/cipso_ipv4.c
+++ b/net/ipv4/cipso_ipv4.c
@@ -2063,9 +2063,10 @@ int cipso_v4_skbuff_setattr(struct sk_buff *skb,
u32 opt_len;
int len_delta;
- buf_len = cipso_v4_genopt(buf, buf_len, doi_def, secattr);
- if (buf_len < 0)
- return buf_len;
+ ret_val = cipso_v4_genopt(buf, buf_len, doi_def, secattr);
+ if (ret_val < 0)
+ return ret_val;
+ buf_len = ret_val;
opt_len = (buf_len + 3) & ~3;
/* we overwrite any existing options to ensure that we have enough
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists