[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081031182207.GD4310@tuxdriver.com>
Date: Fri, 31 Oct 2008 14:22:07 -0400
From: "John W. Linville" <linville@...driver.com>
To: Wang Chen <wangchen@...fujitsu.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Jeff Garzik <jgarzik@...ox.com>,
NETDEV <netdev@...r.kernel.org>, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 16/18] netdevice zd1201: Convert directly reference of
netdev->priv to netdev->ml_priv
On Fri, Sep 05, 2008 at 11:29:36AM +0800, Wang Chen wrote:
> We have some reasons to kill netdev->priv:
> 1. netdev->priv is equal to netdev_priv().
> 2. netdev_priv() wraps the calculation of netdev->priv's offset, obviously
> netdev_priv() is more flexible than netdev->priv.
> But we cann't kill netdev->priv, because so many drivers reference to it
> directly.
>
> OK, becasue Dave S. Miller said, "every direct netdev->priv usage is a bug",
> and I want to kill netdev->priv later, I decided to convert all the direct
> reference of netdev->priv first.
>
> Different to readonly reference of netdev->priv, in this driver, netdev->priv
> was changed. I use netdev->ml_priv to replace netdev->priv.
>
> Signed-off-by: Wang Chen <wangchen@...fujitsu.com>
I don't think this is the right approach for this driver. Alternative
patch to follow...
John
--
John W. Linville Linux should be at the core
linville@...driver.com of your literate lifestyle.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists