netdev - Re: [RESEND][PATCH 2.6.28] myri10ge: fix stop/go mmio ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <490A8E45.909@garzik.org>
Date:	Fri, 31 Oct 2008 00:49:09 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Brice Goglin <brice@...i.com>
CC:	netdev@...r.kernel.org
Subject: Re: [RESEND][PATCH 2.6.28] myri10ge: fix stop/go mmio ordering

Brice Goglin wrote:
> Use mmiowb() to ensure "stop" and "go" commands are sent in order on ia64.
> 
> Signed-off-by: Brice Goglin <brice@...i.com>
> 
> --- linux-git/drivers/net/myri10ge/myri10ge.c	2008-10-30 08:15:37.000000000 +0100
> +++ linux-tmp/drivers/net/myri10ge/myri10ge.c	2008-10-30 08:17:54.000000000 +0100
> @@ -75,7 +75,7 @@
>  #include "myri10ge_mcp.h"
>  #include "myri10ge_mcp_gen_header.h"
>  
> -#define MYRI10GE_VERSION_STR "1.4.3-1.371"
> +#define MYRI10GE_VERSION_STR "1.4.3-1.375"
>  
>  MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
>  MODULE_AUTHOR("Maintainer: help@...i.com");
> @@ -1393,6 +1393,7 @@
>  		if (tx->req == tx->done) {
>  			tx->queue_active = 0;
>  			put_be32(htonl(1), tx->send_stop);
> +			mmiowb();
>  		}
>  		__netif_tx_unlock(dev_queue);
>  	}
> @@ -2864,6 +2865,7 @@
>  	if ((mgp->dev->real_num_tx_queues > 1) && tx->queue_active == 0) {
>  		tx->queue_active = 1;
>  		put_be32(htonl(1), tx->send_go);
> +		mmiowb();
>  	}
>  	tx->pkt_start++;
>  	if ((avail - count) < MXGEFW_MAX_SEND_DESC) {
> 

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html