netdev - Re: question: emulate_large_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081031.000100.212963588.davem@davemloft.net>
Date:	Fri, 31 Oct 2008 00:01:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hummerbliss@...il.com
Cc:	linux-net@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: question: emulate_large_send_offload

From: David Miller <davem@...emloft.net>
Date: Thu, 30 Oct 2008 14:37:47 -0700 (PDT)

> netdev added to CC:
> 
> > Any particular reason emulate_large_send_offload call is still present in the
> > loopback_xmit (drivers/net/loopback.c)? It looks like the function has been
> > removed recently (git commit 7447ef63cf2dfdc444f4c72ae13f604350b2e25f).

Thanks for pointing this out, I've commited the following to
correct it.

commit 3a8af722495469e9c550386b910c5b93c91cf107
Author: David S. Miller <davem@...emloft.net>
Date:   Fri Oct 31 00:00:33 2008 -0700

    net: Really remove all of LOOPBACK_TSO code.
    
    As noticed by Saikiran Madugula, commit 7447ef63cf2dfdc444f4c72ae13f604350b2e25f
    ("loopback: Remove rest of LOOPBACK_TSO code.") got rid of
    emulate_large_send_offload() but didn't get rid of the call
    site as well.
    
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/drivers/net/loopback.c b/drivers/net/loopback.c
index 3b43bfd..b1ac63a 100644
--- a/drivers/net/loopback.c
+++ b/drivers/net/loopback.c
@@ -76,15 +76,6 @@ static int loopback_xmit(struct sk_buff *skb, struct net_device *dev)
 
 	skb->protocol = eth_type_trans(skb,dev);
 
-#ifdef LOOPBACK_TSO
-	if (skb_is_gso(skb)) {
-		BUG_ON(skb->protocol != htons(ETH_P_IP));
-		BUG_ON(ip_hdr(skb)->protocol != IPPROTO_TCP);
-
-		emulate_large_send_offload(skb);
-		return 0;
-	}
-#endif
 	dev->last_rx = jiffies;
 
 	/* it's OK to use per_cpu_ptr() because BHs are off */
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html