netdev - [PATCH net-next] tg3: inconsistent interrupt value reported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081031155421.GB6181@gospo.rdu.redhat.com>
Date:	Fri, 31 Oct 2008 11:54:22 -0400
From:	Andy Gospodarek <andy@...yhouse.net>
To:	mcarlson@...adcom.com, netdev@...r.kernel.org
Cc:	mchan@...adcom.com, davem@...emloft.net
Subject: [PATCH net-next] tg3: inconsistent interrupt value reported


Systems that use MSI do not report the correct 'Interrupt' value in
ifconfig output.  This patch sets dev->irq after initializing the
interrupt as the value will change when using MSI.

I suspect this is a problem with a lot of drivers, so I'll snoop around
and post some more patches if needed.

Signed-off-by: Andy Gospodarek <andy@...yhouse.net>
---

 tg3.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index eb9f8f3..fa95e99 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -7892,6 +7892,7 @@ static int tg3_request_irq(struct tg3 *tp)
 	irq_handler_t fn;
 	unsigned long flags;
 	struct net_device *dev = tp->dev;
+	int ret;
 
 	if (tp->tg3_flags2 & TG3_FLG2_USING_MSI) {
 		fn = tg3_msi;
@@ -7904,7 +7905,9 @@ static int tg3_request_irq(struct tg3 *tp)
 			fn = tg3_interrupt_tagged;
 		flags = IRQF_SHARED | IRQF_SAMPLE_RANDOM;
 	}
-	return (request_irq(tp->pdev->irq, fn, flags, dev->name, dev));
+	ret = request_irq(tp->pdev->irq, fn, flags, dev->name, dev);
+	dev->irq = tp->pdev->irq;
+	return ret;
 }
 
 static int tg3_test_interrupt(struct tg3 *tp)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html