netdev - Re: [PATCH] net: add documentation for skb recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081101025929.GA13377@xi.wantstofly.org>
Date:	Sat, 1 Nov 2008 03:59:29 +0100
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, rdunlap@...otime.net, netdev@...r.kernel.org
Subject: Re: [PATCH] net: add documentation for skb recycling

On Sun, Oct 26, 2008 at 11:05:00PM -0700, David Miller wrote:

> > How about tweaking this slightly and saying:
> > 
> >  * 	Checks that the skb passed in is not shared or cloned, and
> >  *	that it is linear and its head portion at least as large as
> >  *	skb_size so that it can be recycled as a receive buffer.
> >  * 	If these conditions are met, this function does any necessary
> >  *	reference count dropping and cleans up the skbuff as if it
> >  *	just came from __alloc_skb().
> 
> I like this tweak, someone please send me the final version with
> proper signoffs etc.

How about this:



From: Stephen Hemminger <shemminger@...tta.com>
Subject: net: add documentation for skb recycling

Commit 04a4bb55bcf35b63d40fd2725e58599ff8310dd7 ("net: add
skb_recycle_check() to enable netdriver skb recycling") added a
method for network drivers to recycle skbuffs, but while use of
this mechanism was documented in the commit message, it should
really have been added as a docbook comment as well -- this
patch does that.

Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 4e22e3a..ebb6b94 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -449,6 +449,18 @@ void kfree_skb(struct sk_buff *skb)
 	__kfree_skb(skb);
 }
 
+/**
+ *	skb_recycle_check - check if skb can be reused for receive
+ *	@skb: buffer
+ *	@skb_size: minimum receive buffer size
+ *
+ *	Checks that the skb passed in is not shared or cloned, and
+ *	that it is linear and its head portion at least as large as
+ *	skb_size so that it can be recycled as a receive buffer.
+ *	If these conditions are met, this function does any necessary
+ *	reference count dropping and cleans up the skbuff as if it
+ *	just came from __alloc_skb().
+ */
 int skb_recycle_check(struct sk_buff *skb, int skb_size)
 {
 	struct skb_shared_info *shinfo;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html