netdev - Re: [PATCH] net: kconfig cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <490DACC3.2050203@garzik.org>
Date:	Sun, 02 Nov 2008 08:36:03 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	netdev@...r.kernel.org, davem@...emloft.net,
	Andrew Gallatin <gallatin@...i.com>
Subject: Re: [PATCH] net: kconfig cleanup

Jeff Kirsher wrote:
> The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this
> patch adds a description to the kconfig option.
> 
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> CC: Andrew Gallatin <gallatin@...i.com>
> ---
> 
>  drivers/net/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f749b40..b13a7ff 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2437,7 +2437,7 @@ config IXGBE
>  	  will be called ixgbe.
>  
>  config IXGBE_DCA
> -	bool
> +	bool "Enable DCA"
>  	default y
>  	depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
>  
> @@ -2489,7 +2489,7 @@ config MYRI10GE
>  	  will be called myri10ge.
>  
>  config MYRI10GE_DCA
> -	bool
> +	bool "Enable DCA"
>  	default y
>  	depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)

If you're gonna do that, please add useful help text for the user who 
has no idea what this means.  (IGB_DCA needs this as well)

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html