netdev - Re: warnings from recent format patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081102.235722.203621135.davem@davemloft.net>
Date:	Sun, 02 Nov 2008 23:57:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	harvey.harrison@...il.com, netdev@...r.kernel.org
Subject: Re: warnings from recent format patch

From: Stephen Hemminger <shemminger@...tta.com>
Date: Sun, 2 Nov 2008 16:33:11 -0800

> Even if you can't run it, please compile and run sparse on your
> code.
> 
>  CC [M]  net/sunrpc/xprtsock.o
> net/sunrpc/xprtsock.c: In function ‘xs_format_ipv4_peer_addresses’:
> net/sunrpc/xprtsock.c:287: warning: too many arguments for format

Thanks so much for the patch Stephen, that's so much
better than what most people do, which is just whine.

commit e0db4a786bbd73145b4feb45c75d49b6e60fe72c
Author: David S. Miller <davem@...emloft.net>
Date:   Sun Nov 2 23:57:06 2008 -0800

    sunrpc: Fix build warning due to typo in %pI4 format changes.
    
    Noticed by Stephen Hemminger.
    
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index c14d3fd..5cbb404 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -284,7 +284,7 @@ static void xs_format_ipv4_peer_addresses(struct rpc_xprt *xprt,
 
 	buf = kzalloc(20, GFP_KERNEL);
 	if (buf) {
-		snprintf(buf, 20, "pI4", &addr->sin_addr.s_addr);
+		snprintf(buf, 20, "%pI4", &addr->sin_addr.s_addr);
 	}
 	xprt->address_strings[RPC_DISPLAY_ADDR] = buf;