netdev - Re: smc91x: commit 51ac3beffd4afaea4350526cf01fe74aaff25eff breaks compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081103081412.GD18445@roarinelk.homelinux.net>
Date:	Mon, 3 Nov 2008 09:14:12 +0100
From:	Manuel Lauss <mano@...rinelk.homelinux.net>
To:	David Miller <davem@...emloft.net>
Cc:	vapier@...too.org, netdev@...r.kernel.org
Subject: Re: smc91x: commit 51ac3beffd4afaea4350526cf01fe74aaff25eff breaks
	compilation

On Mon, Nov 03, 2008 at 12:08:58AM -0800, David Miller wrote:
> From: Manuel Lauss <mano@...rinelk.homelinux.net>
> Date: Mon, 3 Nov 2008 09:03:40 +0100
> 
> > To be more precise:
> > 
> > smc91x configured purely through platform_data:
> > 
> > ATTRIB_SIZE is ((64*1024) << SMC_IO_SHIFT)
> > with SMC_IO_SHIFT being "lp->io_shift" (smc91x.h line 450).
> > 
> > So please revert this patch.
> 
> That's not the correct action, because that brings the
> stupid warning back in some configurations.
> 
> See my other reply for the fix I'll be using, which
> brings back the variables but adds the appropriate
> __maybe_unused markers to them.

Thank you.  I sent the above reply before your fix hit my
mailbox.  I don't really care _how_ it's being fixed, I just
want the damn thing to work ;-)

Thanks again,
	Manuel Lauss

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html