netdev - Re: [PATCH 3/7] net: replace NIPQUAD() in net/netfilter/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43ca39800811030856u5acf9601s6aef81887f19f859@mail.gmail.com>
Date:	Mon, 3 Nov 2008 17:56:08 +0100
From:	"Julius Volz" <julius.volz@...il.com>
To:	"Harvey Harrison" <harvey.harrison@...il.com>
Cc:	"David Miller" <davem@...emloft.net>,
	linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 3/7] net: replace NIPQUAD() in net/netfilter/

Hi,

On Fri, Oct 31, 2008 at 1:13 AM, Harvey Harrison
<harvey.harrison@...il.com> wrote:
> Using NIPQUAD() with NIPQUAD_FMT, %d.%d.%d.%d or %u.%u.%u.%u
> can be replaced with %pI4
>
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
[...]

I just noticed that this breaks IPv4 addresses in IPVS debug output
(didn't check in other places). It seems that during integer to ASCII
conversion, the converted digits are output the wrong way around (not
endianness though). For example, 10.0.0.254 is output as 01.0.0.452.
Could something be wrong with ip4_addr_string() or put_dec_trunc() in
lib/vsprintf.c?

Julius
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html