netdev - Re: [PATCH 02/15] tg3: Use pci_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081103.165046.71461900.davem@davemloft.net>
Date:	Mon, 03 Nov 2008 16:50:46 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mcarlson@...adcom.com
Cc:	netdev@...r.kernel.org, mchan@...adcom.com, andy@...yhouse.net
Subject: Re: [PATCH 02/15] tg3: Use pci_ioremap_bar()

From: "Matt Carlson" <mcarlson@...adcom.com>
Date: Mon, 3 Nov 2008 02:10:35 -0800

> This patch replaces the existing APE register mapping code with a call
> to pci_ioremap_bar().  The code that maps the main device register space
> did not undergo a similar change because the information derived from
> the pci_resource_start() and pci_resource_len() is still used to
> populate the (optional) mem_start and mem_end netdevice members.
> Replace hardcoded constants where appropriate.
> 
> Signed-off-by: Matt Carlson <mcarlson@...adcom.com>
> Signed-off-by: Michael Chan <mchan@...adcom.com>

Applied, but I think you can simply just remove those
dev->mem_start and dev->mem_end settings, they are
completely useles and if that is the only thing blocking
universal use of pci_ioremap_bar() it is yet another
reason to remove them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html