netdev - [PATCH] hso should register as a WWAN rfkill device, not WLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081104111118.GQ3162@earth.li>
Date:	Tue, 4 Nov 2008 11:11:18 +0000
From:	Jonathan McDowell <noodles@...th.li>
To:	netdev@...r.kernel.org
Cc:	Marcel Holtmann <marcel@...tmann.org>
Subject: [PATCH] hso should register as a WWAN rfkill device, not WLAN

Currently the hso driver registers a WLAN rfkill switch, which is
intended for 802.11 wireless network devices. Given that this driver
supports GSM/HSPA devices it's more appropriate to register a WWAN
rfkill switch type.

Signed-Off-By: Jonathan McDowell <noodles@...th.li>

-----
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 1164c52..3f49e83 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2188,7 +2188,7 @@ static void hso_create_rfkill(struct hso_device *hso_dev,
 	char *rfkn;
 
 	hso_net->rfkill = rfkill_allocate(&interface_to_usbdev(interface)->dev,
-				 RFKILL_TYPE_WLAN);
+				 RFKILL_TYPE_WWAN);
 	if (!hso_net->rfkill) {
 		dev_err(dev, "%s - Out of memory\n", __func__);
 		return;
-----

J.

-- 
Revd. Jonathan McDowell, ULC | Settle down, Beavis.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html