netdev - Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40811040757m4e36699nf7870258929ed768@mail.gmail.com>
Date:	Tue, 4 Nov 2008 08:57:23 -0700
From:	"Grant Likely" <grant.likely@...retlab.ca>
To:	"Marc Pignat" <marc.pignat@...s.ch>
Cc:	"Paulius Zaleckas" <paulius.zaleckas@...tonika.lt>,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-embedded@...r.kernel.org,
	"Laurent Pinchart" <laurentp@...-semaphore.com>,
	"Mike Frysinger" <vapier.adi@...il.com>
Subject: Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

On Tue, Nov 4, 2008 at 8:45 AM, Marc Pignat <marc.pignat@...s.ch> wrote:
> Hiü
>
> On Tuesday 04 November 2008, Paulius Zaleckas wrote:
>> make mdio-gpio work with non OpenFirmware gpio implementation.
>
> of_gpio.c provides generic gpio compatible gpios.
>
> Why not remove all OF specific code from this file and add another one
> creating the struct mdio_gpio_platform_data using OF specific functions?

This is a very simple driver.  There is no need to split it into two
files.  Have two sections of bus binding (OF and non-OF) is just fine.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html