netdev - RE: [PATCH 0/3] WOL fixes for e1000e, e1000 and igb (was: Re: [Bugme-new] [Bug 11865] New: WOL for E100 Doesn't Work Anymore)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F169D4F5E1F1974DBFAFABF47F60C10A0E874918@orsmsx507.amr.corp.intel.com>
Date:	Wed, 5 Nov 2008 11:14:12 -0800
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	David Miller <davem@...emloft.net>,
	"jeff@...zik.org" <jeff@...zik.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"rogerx@....lonestar.org" <rogerx@....lonestar.org>
Subject: RE: [PATCH 0/3] WOL fixes for e1000e, e1000 and igb (was: Re:
 [Bugme-new] [Bug 11865] New: WOL for E100 Doesn't Work Anymore)

Rafael J. Wysocki wrote:
> On Tuesday, 4 of November 2008, Rafael J. Wysocki wrote:
> [--snip--]
>> 
>>> Your work is appeciated, I just didn't realize it would break all
>>> devices that didn't implement it.
>> 
>> In fact it doesn't really break them, you can write 'enabled' to
>> /sys/devices/.../power/wakeup of the device in question and it will
>> work. 
>> 
>>> I'm open to corrections to my point of view above.
>> 
>> Well, before those changes WOL didn't work on any of my machines and
>> now it works on all of them (except for one that hasn't been tested)
>> - with the already merged patches and the two waiting for merging.
>> 
>> Sorry about the problems caused, I'm willing to fix them ASAP.
> 
> BTW, WOL fixes for e1000e, e1000 and igb follow.

Awesome!  Thanks, we are testing them now and will ack/push upstream in
a couple of days (for sure by end of week)

So do you have a count of how many other drivers would need this fix
(regardless of when you'll get to them)

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (6703 bytes)