netdev - Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200811051459.08777.david-b@pacbell.net>
Date:	Wed, 5 Nov 2008 14:59:08 -0800
From:	David Brownell <david-b@...bell.net>
To:	"Grant Likely" <grant.likely@...retlab.ca>
Cc:	"Paulius Zaleckas" <paulius.zaleckas@...tonika.lt>,
	"Mike Frysinger" <vapier.adi@...il.com>, netdev@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-embedded@...r.kernel.org,
	"Laurent Pinchart" <laurentp@...-semaphore.com>
Subject: Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

On Wednesday 05 November 2008, Grant Likely wrote:
> > 	 Maybe the best solution is
> > to write separate driver for OF which will be just wrapper for platform
> > driver... Just like you suggested.

I'd certainly prefer that:  packaging all the OF glue in
a small bit of OF glue code, which doesn't need to affect
the majority of platforms (which don't and won't use OF).

> More complex than necessary.  Just give the driver 2 blocks of binding
> code; one for OF, one for non-OF.  No need to split up the driver.

The preceding discussion pointed out ways the "2 blocks"
approach doesn't currently work well ... minimally, there
is currently no way to do that without much ugly #ifdeffing.

And clearly, you and I view this a bit differently.  I'm
happier to think of these kinds of configuration as one
driver plus *separate* platform glue, while you want to be
modifying every driver to accomodate OF.  Or, by extension,
ACPI and any other hardware abstraction layer that comes
along.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html