netdev - Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200811041604.22947.david-b@pacbell.net>
Date:	Tue, 4 Nov 2008 17:04:22 -0700
From:	David Brownell <david-b@...bell.net>
To:	"Grant Likely" <grant.likely@...retlab.ca>
Cc:	"Paulius Zaleckas" <paulius.zaleckas@...tonika.lt>,
	netdev@...r.kernel.org, linux-arm-kernel@...ts.arm.linux.org.uk,
	linux-embedded@...r.kernel.org,
	"Laurent Pinchart" <laurentp@...-semaphore.com>,
	"Mike Frysinger" <vapier.adi@...il.com>
Subject: Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

On Tuesday 04 November 2008, Grant Likely wrote:
> At this point, instead of #ifdeffing the function signature, I would
> much rather see this generalized as something like
> 'mdio_gpio_setup()'.  Then move the OF and non-OF specific bits into
> two new functions; mdio_ofgpio_probe() and mdio_gpio_probe().  The two
> new functions should be placed with the appropriate bus binding in the
> #ifdef/#else block at the bottom of the file.

Or if possible something that creates a single #ifdef that
ensures dead code elimination will remove the "other" branch,
but ensures all platforms will build both versions:

    #ifdef OF
    #define using_of	true
    #else
    #define using_of	false
    #endif

    ...

    static int __init mdio_gpio_init(void)
    {
	if (using_of)
		return register mdio_ofgpio driver;
	else
		return register mdio_gpio driver;
    }
    subsys_initcall(mdio_gpio_init);

    ...

That's generally the preferred way to handle #ifdeffery.
But I could imagine OF isn't (yet?) set up to handle it.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html