netdev - Re: [PATCH] Move if_mii to userspace in mii.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3993a4980811050314l303c80ft8b07338a909fc34e@mail.gmail.com>
Date:	Wed, 5 Nov 2008 12:14:03 +0100
From:	"Jouke Witteveen" <j.witteveen@...il.com>
To:	netdev@...r.kernel.org
Cc:	wtarreau@...nel.org
Subject: Re: [PATCH] Move if_mii to userspace in mii.h

Dear all,

Please do not apply the proposed patch. It does, of course, not work,
since the ifreq struct need not exist at the point in the file where I
have put the function.
An (ugly?) way around this would to move the function to the end of the file:
--- excerpt ------
#endif /* __KERNEL__ */
#ifdef _LINUX_IF_H

static inline struct mii_ioctl_data *if_mii(struct ifreq *rq)
{
        return (struct mii_ioctl_data *) &rq->ifr_ifru;
}

#endif /* __LINUX_IF_H */
#endif /* __LINUX_MII_H__ */
--- end of excerpt ------
Based on the looks of it I am not sure whether this is a good idea.

Sorry for the inconvenience,
Jouke Witteveen


On Wed, Nov 5, 2008 at 10:42, Jouke Witteveen <j.witteveen@...il.com> wrote:
> Dear all,
>
> There is a convenient routine in include/linux/mii.h called if_mii. It
> is, however, kept away from userspace. A patch is attached that moves
> it back to userspace so that it can be included from outside the
> kernel.
>
> Note that the current mii.h in kernel 2.4 does not hide the function.
>
> Regards,
> Jouke Witteveen
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html