netdev - Re: [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1225974795.3150.1.camel@achroite>
Date:	Thu, 06 Nov 2008 12:33:15 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	jgarzik@...hat.com
Subject: Re: [patch 6/7] drivers/net/sfc/falcon.c: fix min() warnings

On Thu, 2008-11-06 at 00:39 -0500, Jeff Garzik wrote:
> akpm@...ux-foundation.org wrote:
> > From: Andrew Morton <akpm@...ux-foundation.org>
> > 
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_write_limit':
> > drivers/net/sfc/falcon.c:1679: warning: comparison of distinct pointer types lacks a cast
> > drivers/net/sfc/falcon.c: In function 'falcon_spi_read':
> > drivers/net/sfc/falcon.c:1720: warning: comparison of distinct pointer types lacks a cast
> > 
> > Driver seems rather confused about types.  Try to help it.
[...]
> I would prefer min_t()...

Andrew has dropped this patch as it is no longer applicable.  I do have
a patch to clean up the length types which I'll submit later.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html