netdev - Re: [irda-users] [1/3] IRDA: Create new field tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081110164732.GA7511@sortiz.org>
Date:	Mon, 10 Nov 2008 17:47:32 +0100
From:	Samuel Ortiz <samuel@...tiz.org>
To:	Alex Villacís Lasso 
	<avillaci@...bo.fiec.espol.edu.ec>
Cc:	irda-users@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [irda-users] [1/3] IRDA: Create new field tx_extra in skbuff

Hi Alex,

On Mon, Nov 10, 2008 at 11:09:33AM -0500, Alex Villacís Lasso wrote:
> This patch and the other two that follow fix the issue for me under  
> 2.6.28-rc3. Please comment on this, as I am messing around with the  
> skbuff structure, which potentially affects all network stacks.
Adding 32 bytes to _all_ skbs is a no-no.
This is an IrDA specific issue, and it has to be fixed in an IrDA specific
way. My patches work with my irda-usb and mcs7780 dongles. If they dont for
you, then we should dump the kernel stack when we're hitting the problem of
not having reserved enough headroom for the irda cb.
Evgeniy's proposal could also be another solution.


Cheers,
Samuel.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html