netdev - Re: ssb: Fix DMA-API compilation for non-PCI systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081110.135231.96349017.davem@davemloft.net>
Date:	Mon, 10 Nov 2008 13:52:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mb@...sch.de
CC:	netdev@...r.kernel.org
Subject: Re: ssb: Fix DMA-API compilation for non-PCI systems


I applied this since it's a build buster and we should
get it fixed quickly.

But as I look at this, the thing to really do here is get
rid of these stupid switch statements.  None of it is needed.

The layer that sets up the SSB devices should simply save the
generic device pointer for the DMA entity into some new
->dma_dev struct member.

Then you just use generic dma_*() interfaces unilaterally.  For PCI
devices it will "just work".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html