netdev - Re: [PATCH 2.6.27] tcp_htcp: last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 10 Nov 2008 21:50:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Doug.Leith@...m.ie
Cc:	netdev@...r.kernel.org, shemminger@...tta.com,
	lachlan.andrew@...il.com, lstewart@...m52.net
Subject: Re: [PATCH 2.6.27] tcp_htcp: last_cong bug fix

From: Douglas Leith <Doug.Leith@...m.ie>
Date: Sun, 09 Nov 2008 19:09:24 +0000

> This patch fixes a minor bug in tcp_htcp.c which has been
> highlighted by Lachlan Andrew and Lawrence Stewart.  Currently, the
> time since the last congestion event, which is stored in variable
> last_cong, is reset whenever there is a state change into
> TCP_CA_Open.  This includes transitions of the type
> TCP_CA_Open->TCP_CA_Disorder->TCP_CA_Open which are not associated
> with backoff of cwnd.  The patch changes last_cong to be updated
> only on transitions into TCP_CA_Open that occur after experiencing
> the congestion-related states TCP_CA_Loss, TCP_CA_Recovery,
> TCP_CA_CWR.

Thank you for this fix.  Could you fix a few things up for
me and resubmit this?

1) Please provide a proper Signed-off-by: line as per
   linux/Documentation/SubmittingPatches

2) Please -p1 root your patches at the top level of
   the kernel source tree, again the SubmittingPatches
   document helps explain ways to do this

3) Please fix up a few coding style errors, such as:

> +               ca->undo_last_cong=0; // flag that ca->last_cong is not to be reset when enter TCP_CA_Open state

   Please don't use C++ style comments, use normal C ones,
   and please don't let the line exceed much more than 80
   columns.

   Also, please put one space on each side of the equal sign in the
   assignment.

> +                       if (ca->undo_last_cong) {
> +                               ca->last_cong=jiffies;
> +                               ca->undo_last_cong=0;
> +                       }

   Again, please put spaces around the assignment equal sign.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html