netdev - Re: [PATCH 2/2] dsa: fix master interface allmulti/promisc handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20081110.215322.106664497.davem@davemloft.net>
Date:	Mon, 10 Nov 2008 21:53:22 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	buytenh@...tstofly.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] dsa: fix master interface allmulti/promisc handling

From: Lennert Buytenhek <buytenh@...tstofly.org>
Date: Mon, 10 Nov 2008 00:23:09 +0100

> Before commit b6c40d68ff6498b7f63ddf97cf0aa818d748dee7 ("net: only
> invoke dev->change_rx_flags when device is UP"), the dsa driver could
> sort-of get away with only fiddling with the master interface's
> allmulti/promisc counts in ->change_rx_flags() and not touching them
> in ->open() or ->stop().  After this commit (note that it was merged
> almost simultaneously with the dsa patches, which is why this wasn't
> caught initially), the breakage that was already there became more
> apparent.
> 
> Since it makes no sense to keep the master interface's allmulti or
> promisc count pinned for a slave interface that is down, copy the vlan
> driver's sync logic (which does exactly what we want) over to dsa to
> fix this.
> 
> Bug report from Dirk Teurlings <dirk@...xia.nl> and Peter van Valderen
> <linux@...rew.com>.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@...vell.com>
> Tested-by: Dirk Teurlings <dirk@...xia.nl>
> Tested-by: Peter van Valderen <linux@...rew.com>

Also applied, thanks a lot.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html